Skip to content

fix: Less hacky vector implementation #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iwoplaza wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Less hacky vector implementation #2251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/typegpu/src/core/root/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ function toVec3(arr: readonly (number | undefined)[]): v3u {
}

const workgroupSizeConfigs = [
vec3u(1, 1, 1),
vec3u(256, 1, 1),
vec3u(16, 16, 1),
vec3u(8, 8, 4),
[1, 1, 1],
[256, 1, 1],
[16, 16, 1],
[8, 8, 4],
] as const;

export class TgpuGuardedComputePipelineImpl<
Expand All @@ -124,15 +124,15 @@ export class TgpuGuardedComputePipelineImpl<
#root: ExperimentalTgpuRoot;
#pipeline: TgpuComputePipeline;
#sizeUniform: TgpuUniform<Vec3u>;
#workgroupSize: v3u;
#workgroupSize: [number, number, number];

#lastSize: v3u;
#lastSize: [number, number, number];

constructor(
root: ExperimentalTgpuRoot,
pipeline: TgpuComputePipeline,
sizeUniform: TgpuUniform<Vec3u>,
workgroupSize: v3u,
workgroupSize: [number, number, number],
) {
this.#root = root;
this.#pipeline = pipeline;
Expand Down Expand Up @@ -228,7 +228,7 @@ class WithBindingImpl implements WithBinding {
throw new Error('Guarded compute callback only supports up to three dimensions.');
}

const workgroupSize = workgroupSizeConfigs[callback.length] as v3u;
const workgroupSize = workgroupSizeConfigs[callback.length] as [number, number, number];
const wrappedCallback = fn([u32, u32, u32])(callback as (...args: number[]) => void);

const sizeUniform = root.createUniform(vec3u);
Expand Down
Loading
Loading