Open
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (349 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
iwoplaza
force-pushed
the
fix/allow-empty-vertex-auto-in
branch
2 times, most recently
from
1abc665 to
f7acb4f
Compare
iwoplaza
force-pushed
the
fix/allow-empty-vertex-auto-in
branch
from
f7acb4f to
ef8ae95
Compare
iwoplaza
changed the title
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
Copilot and
reczkok
There was a problem hiding this comment.
Pull request overview
This PR introduces type aliases AutoInEmpty to the TgpuVertexFn and TgpuFragmentFn namespaces, providing a cleaner way to annotate entry functions that have no custom attributes or varyings. This addresses a TypeScript convention where using {} directly as a type is discouraged, offering developers a named alternative via AutoInEmpty which is an alias for AutoIn<{}>.
Changes:
- Added
TgpuVertexFn.AutoInEmptytype alias for_AutoVertexIn<{}> - Added
TgpuFragmentFn.AutoInEmptytype alias forAutoFragmentIn<{}> - Added test case demonstrating the use of the new type aliases for entry functions with no custom inputs
- Added necessary type imports to test file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/typegpu/src/core/function/tgpuVertexFn.ts |
Introduces AutoInEmpty type alias for vertex functions |
packages/typegpu/src/core/function/tgpuFragmentFn.ts |
Introduces AutoInEmpty type alias for fragment functions |
packages/typegpu/tests/renderPipeline.test.ts |
Adds imports and comprehensive test case demonstrating the new type aliases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
{}as a type is discouraged by TypeScript, but it seems likeTgpuVertexFn.AutoIn<Record<string, never>>doesn't have the behavior we expect, soTgpuVertexFn.AutoInEmptyis an alias forTgpuVertexFn.AutoIn<{}>which we can adjust if we ever find out how to makeRecord<string, never>behave properly.