Open
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (349 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
Copilot and
reczkok
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the texture and sampler creation APIs by promoting createTexture, createSampler, and createComparisonSampler from the experimental root['~unstable'] interface to the main stable TgpuRoot interface. This is a major API stabilization that removes the need for the unstable accessor when creating textures and samplers.
Changes:
- Added stable
createTexture,createSampler, andcreateComparisonSamplermethod signatures to the mainTgpuRootinterface - Added deprecation notices to the experimental versions in
ExperimentalTgpuRoot - Updated all 40+ example files throughout the codebase to use the stable API
- Updated all test files to use the stable API
- Updated all documentation to reflect the stable API usage
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/typegpu/src/core/root/rootTypes.ts | Added stable method signatures to TgpuRoot and deprecation notices to ExperimentalTgpuRoot |
| packages/typegpu/tests/unplugin/autoname.test.ts | Updated to use stable root.createTexture, root.createSampler, root.createComparisonSampler |
| packages/typegpu/tests/std/texture/textureSample.test.ts | Updated texture creation to use stable API |
| packages/typegpu/tests/std/texture/textureLoad.test.ts | Updated texture creation to use stable API |
| packages/typegpu/tests/bindGroupLayout.test.ts | Updated sampler and texture creation to use stable API |
| apps/typegpu-docs/src/examples/* | 30+ example files updated to use stable texture and sampler creation APIs |
| apps/typegpu-docs/src/content/docs/fundamentals/textures.mdx | Updated documentation examples and descriptions to use stable APIs |
| apps/typegpu-docs/src/content/docs/fundamentals/data-schemas.mdx | Updated texture creation examples |
| apps/typegpu-docs/src/content/docs/fundamentals/accessors.mdx | Updated accessor examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reczkok
reviewed
Apr 3, 2026
|
|
||
| export function createBackgroundCubemap(root: TgpuRoot): BackgroundCubemap { | ||
| const texture = root['~unstable'] | ||
| const texture = root |
Contributor
There was a problem hiding this comment.
Don’t we prefer the formatting to change in those cases (with .createTexture immediately after root)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.