Open
Conversation
Adds a new `insertText` command that inserts plain text into the attributed string without replacing existing rich content (images, mentions, etc). Accepts optional start/end position parameters (visible indices, skipping ZWSPs). When omitted, inserts at the current selection. Implemented for both iOS and Android.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
insertTextcommand that inserts plain text into the input without replacing existing rich content (images, mentions, etc).Accepts optional
startandendposition parameters (visible indices, skipping ZWSPs). When omitted or set to -1, inserts at the current selection/cursor position.setValuereplaces the entire content, andsetImagereplaces the selection with an image, but there's no way to programmatically insert plain text at a position without destroying rich content.This is intentionally plain-text-only and complements #409 (
insertValue), which targets rich/HTML content insertion.Test Plan
setImageinsertText(' ')— a space should appear after the image without destroying itinsertText('hello', 0)— text should be inserted at position 0insertText('x', 2, 5)— should replace characters 2-5 with 'x'Compatibility
Checklist