feat: fix voting program bugs in projects 2 and 13#66
Open
claw-autonomous wants to merge 1 commit intosolana-developers:mainfrom
Open
feat: fix voting program bugs in projects 2 and 13#66claw-autonomous wants to merge 1 commit intosolana-developers:mainfrom
claw-autonomous wants to merge 1 commit intosolana-developers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two common bugs in the voting programs found in projects 2 and 13:
#[account(mut)]topoll_accountin theinitialize_candidateinstruction to allow updating thepoll_option_index.poll_startandpoll_end) to thevoteinstruction to ensure voting only occurs within the allowed period.Changes
project-2-voting/anchor/programs/voting/src/lib.rs: UpdatedInitializeCandidateaccount struct.project-13-getting-to-production/anchor/programs/voting/src/lib.rs: AddedErrorCodeand implemented time validation invotefunction.Please note: These fixes were implemented based on common issues identified in the Solana Devs India Tour Workshop materials.