Skip to content

Fix: make biome tests pass, lint code, upgrade litesvm to fix Native / Pinocchio tests.#550

Open
mikemaccana wants to merge 6 commits intosolana-developers:mainfrom
mikemaccana:fix-biome-errors
Open

Fix: make biome tests pass, lint code, upgrade litesvm to fix Native / Pinocchio tests.#550
mikemaccana wants to merge 6 commits intosolana-developers:mainfrom
mikemaccana:fix-biome-errors

Conversation

@mikemaccana
Copy link
Copy Markdown
Contributor

@mikemaccana mikemaccana commented Apr 1, 2026

Commits

Make 'biome check' (formatting and linting) pass

  • This repo was already configured to use biome for linting - remove unnecessary prettierrc files from two projects
  • Add biome checks to GitHub actions (they were already being used as a precommit hook)
  • Configure VS Code to use Biome as the formatter
  • Upgrade Biome from v1.8.1 → v2.4.10 (aligns package.json pin with what pnpx was already fetching). Fix biome check --apply--write (flag renamed in v2) in the lint-staged pre-commit hook
  • Configure formatter: 2-space indent, single quotes, 120-char line width (matches existing code style)
  • Fix all lint errors across the codebase - Anchor test files that use any for generated types get per-line biome-ignore comments, we'll change to LiveSVM tests soon.

Fix: this project uses pnpm, use it

  • setup-node@v5 tries to cache pnpm (triggered by the packageManager field) before pnpm is installed, causing "pnpm: command not found". Fixed by adding pnpm/action-setup@v4 before setup-node in both workflows.
  • Remove stale yarn.lock (the repo uses pnpm)

Fix: Native and Pinocchio tests by upgrading LiteSVM

  • litesvm 0.8.1 fails to compile against current Solana stable because internal APIs changed (ProgramCacheForTxBatch.environments removed, TransactionError lifetime added). v0.11.0 has been updated for these changes.

All workflows green on mikemaccana/program-examples fix-biome-errors

  • ✅ TypeScript (Biome check)
  • ✅ Rust Lint (fmt + clippy)
  • ✅ Native
  • ✅ Pinocchio
  • ✅ Anchor

🤖 Generated with Claude Code

mikemaccana and others added 5 commits April 1, 2026 12:21
- Biome is the existing TS formatter / linter, however it was failing.
- Upgrade to Biome V2, run biome on GitHub Actions (it's already used in a precommit hook)
- Add a biome config file to match what most of the existing code uses, plus Anchor defaults
- Add missing Tailwind options to check CSS files with Tailwind directives
- Skip some of the 'any' tests in Anchor TS files - these will be moved to LiteSVM
…workflows

packageManager field in package.json causes setup-node to look for pnpm
before it is installed, failing with "Unable to locate executable file: pnpm".

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…current Solana stable

litesvm 0.8.1 failed to compile against current Solana stable because internal
Solana APIs changed (ProgramCacheForTxBatch.environments field removed,
TransactionError lifetime added). litesvm 0.11.0 has been updated for these
API changes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mikemaccana mikemaccana changed the title Fix: biome v2, lint errors, pnpm setup, litesvm upgrade Fix: make biome tests pass, lint errors code, upgrade litesvm to fix Native / Pinocchio tests. Apr 1, 2026
@mikemaccana mikemaccana changed the title Fix: make biome tests pass, lint errors code, upgrade litesvm to fix Native / Pinocchio tests. Fix: make biome tests pass, lint code, upgrade litesvm to fix Native / Pinocchio tests. Apr 1, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fix: use inline emoji instead of GitHub shortcodes in README

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant