feature: Fetch IDL from RPC endpoint fails#693
Open
KartikSoneji wants to merge 2 commits intosolana-foundation:masterfrom
Open
feature: Fetch IDL from RPC endpoint fails#693KartikSoneji wants to merge 2 commits intosolana-foundation:masterfrom
KartikSoneji wants to merge 2 commits intosolana-foundation:masterfrom
Conversation
|
@KartikSoneji is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5befcc5 in 2 minutes and 39 seconds. Click for details.
- Reviewed
110lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. app/providers/anchor.tsx:57
- Draft comment:
Caching key does not include the cluster. If the same program/address and URL are used with different clusters, they may collide. Consider including the cluster (e.g.${programAddress}-${url}-${cluster}) in the key. - Reason this comment was not posted:
Comment was on unchanged code.
2. app/providers/anchor.tsx:67
- Draft comment:
The 'async' keyword in the .then callback is unnecessary since no 'await' is used. Removing it could simplify the code. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The async keyword is indeed unnecessary here since no await is used in the function body. While technically correct, this is a very minor code style issue that doesn't affect functionality. The code works perfectly fine either way. This feels like nitpicking that doesn't meaningfully improve code quality. The comment is technically correct - the async is unnecessary. But am I being too harsh in dismissing minor code style improvements? While technically correct, we should focus on more impactful code quality issues. This change is too minor to warrant a PR comment. Delete this comment as it suggests an extremely minor code style change that doesn't meaningfully improve the codebase.
3. app/providers/anchor.tsx:66
- Draft comment:
The catch block used as a fallback discards the error details by using an underscore (_). Capturing and logging the error (e.g. using .catch(error => ...)) would aid in debugging. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_aU3WloGqszVNiOGq
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
scutuatua-crypto
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fallback to try to fetch a program's IDL via RPC if the
/api/anchorendpoint fails.Type of change
Testing
Simulated
/api/anchorfailing by mocking responses.Related Issues
Checklist
Additional Notes
Important
Adds fallback to fetch IDL via RPC if API endpoint fails in
anchor.tsx.fetchIdlFromApi()andfetchIdlFromRpc()functions inanchor.tsxto fetch IDL from API and RPC respectively.useIdlFromAnchorProgramSeed()to usefetchIdlFromApi()and fallback tofetchIdlFromRpc()if API call fails.cachedAnchorProgramPromisesto store promises and results for IDL fetching.This description was created by
for 5befcc5. You can customize this summary. It will automatically update as commits are pushed.