Make tx cost consistent across block page and transaction signature page#764
Open
rajgoesout wants to merge 1 commit intosolana-foundation:masterfrom
Open
Make tx cost consistent across block page and transaction signature page#764rajgoesout wants to merge 1 commit intosolana-foundation:masterfrom
rajgoesout wants to merge 1 commit intosolana-foundation:masterfrom
Conversation
|
@rajgoesout is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Show `Not Supported Slot` instead of showing 0 value or making the component disappear. Fixes solana-foundation#662
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 2896365 in 1 minute and 28 seconds. Click for details.
- Reviewed
54lines of code in2files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. app/components/block/BlockHistoryCard.tsx:119
- Draft comment:
Removing the default fallback (0) for costUnits is intentional. Ensure that a legitimate 0 is displayed as '0' while undefined correctly shows 'Not Supported Slot'. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. app/components/block/BlockHistoryCard.tsx:172
- Draft comment:
Sorting now uses '(b.costUnits ?? 0) - (a.costUnits ?? 0)'. Confirm that treating undefined as 0 meets the desired sort order. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. app/components/block/BlockHistoryCard.tsx:345
- Draft comment:
The cell now displays 'Not Supported Slot' when costUnits is undefined, ensuring UI consistency. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it simply states what the code does without providing any suggestions or asking for clarifications. It doesn't align with the rules for useful comments.
4. app/tx/[signature]/page-client.tsx:350
- Draft comment:
Always rendering the Transaction cost row with a fallback of 'Not Supported Slot' makes the UI consistent with BlockHistoryCard. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states that the change is good for consistency, which does not align with the rules for useful comments.
Workflow ID: wflow_klfIv93GePd6YV9D
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
2896365 to
f1a5ac7
Compare
Author
|
cc @jacobcreech |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make tx costUnits consistent across block page and transaction signature page (show
Not Supported Slotinstead of showing 0 value or making the component disappear).Type of change
Screenshots
Testing
Related Issues
Fixes #662
Checklist
Additional Notes
Important
Fix transaction cost display to show 'Not Supported Slot' for undefined cost units in block and transaction signature pages.
costUnitsinBlockHistoryCard.tsxandpage-client.tsxinstead of 0 or hiding the component.BlockHistoryCard.tsxto handle undefinedcostUnitsby treating them as 0.This description was created by
for 2896365. You can customize this summary. It will automatically update as commits are pushed.