-
Notifications
You must be signed in to change notification settings - Fork 3
improve layer build #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve layer build #207
Conversation
cheempz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisit @xuan-cao-swi! I think it's all working, but there could a few more improvements. The main one i'll actually describe here:
Right now we're hardcoding and peppering in various places the ruby version, which can get easily out of sync. How about making the versions a workflow variable that's easily visible and changed in once place?
Updated to use single env variable from github action file that define all ruby version. |
cheempz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the revisit @xuan-cao-swi!
|
Actually, running into an issue when i tried the |
My bad only saw the changes from a single commit
cheempz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Test (if applicable)
Layer building succeeded (action).
Tested on aws lambda.