Skip to content

Conversation

@xuan-cao-swi
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi commented Jul 24, 2025

Description

  1. added more log output
  2. use gem path to install gem
  3. updated the gem version extraction method for reverselab

Test (if applicable)

Layer building succeeded (action).
Tested on aws lambda.

@xuan-cao-swi xuan-cao-swi marked this pull request as ready for review July 24, 2025 16:51
@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner July 24, 2025 16:51
@xuan-cao-swi xuan-cao-swi requested a review from cheempz July 25, 2025 17:25
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisit @xuan-cao-swi! I think it's all working, but there could a few more improvements. The main one i'll actually describe here:

Right now we're hardcoding and peppering in various places the ruby version, which can get easily out of sync. How about making the versions a workflow variable that's easily visible and changed in once place?

@xuan-cao-swi
Copy link
Contributor Author

Right now we're hardcoding and peppering in various places the ruby version, which can get easily out of sync. How about making the versions a workflow variable that's easily visible and changed in once place?

Updated to use single env variable from github action file that define all ruby version.

@xuan-cao-swi xuan-cao-swi requested a review from cheempz July 28, 2025 20:38
cheempz
cheempz previously approved these changes Jul 28, 2025
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the revisit @xuan-cao-swi!

@cheempz
Copy link
Contributor

cheempz commented Jul 29, 2025

Actually, running into an issue when i tried the 7_0_0.prev3 layer in an aarch64 Lambda, seems google protobuf cannot be found. will send you the logs.

@raphael-theriault-swi raphael-theriault-swi self-requested a review July 31, 2025 20:28
@raphael-theriault-swi raphael-theriault-swi dismissed their stale review July 31, 2025 20:29

My bad only saw the changes from a single commit

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuan-cao-swi xuan-cao-swi merged commit 54539c3 into main Aug 6, 2025
49 of 50 checks passed
@xuan-cao-swi xuan-cao-swi deleted the lambda-fix branch August 6, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants