Update moduleResolution
#545
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moduleResolution: "node"is a legacy setting that will soon be deprecated. It's intended forNode < 10.NodeNexttargets Node 16 and onwards.Implementation
.jsextension to all relative importsmoduleResolutiontoNodeNextmoduletoNodeNextskipLibCheck: trueType Analysis
Latest on NPM
@solidjs/router(ignored) 🥴 Internal resolution error
This PR
@solidjs/routerpnpx @arethetypeswrong/cli --profile esm-only --pack .Final note
Since type-checks and build passes, I don't expect any decrease in compatibility going forward. But adding the
.jsextension even when keepingmodeResolution: nodeseems to have helpedtsc, I expect this new setting to make types more reliable.