Add support for EdDSA/Minisign signatures to sign-hash/sign-file, also add support for choosing credential algorithm to make-credential#137
Open
stevenwdv wants to merge 9 commits intosolokeys:mainfrom
Conversation
…credential (v0.0.30 version)
…largely from branch minisign(-v0.0.27)), via a custom CTAP command, see stevenwdv/solo:sign-hash. (v0.0.30 version) Note that sign-hash now uses HEX credentials just like make-credential, and it will respect the credential algorithm
…n-fido2. Display default value for `--alg` in help.
…ign-host to make-credential to quickly set RP ID to this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for EdDSA pre-hashed signatures to
sign-file(solokeys/solo1#397), possibly including a trusted comment according to Minisign.New
sign-fileflags:If the
--minisignflag is passed, the signature will using pre-hashing with Blake2b-512 instead of SHA-256 and the signature file will be a Minisign-compatible signature. The flag can only be used with EdDSA credentials.To be able to choose the credential type, I added the following flag to
make-credential:To view supported algorithms, use the new
solo key list-algorithmscommand.make-credentialnow also supports saving Minisign keys for EdDSA credentials, and it prints the public key:Breaking change: the
credential_idparameter is now assumed to be a HEX credential, to make it consistent withmake-credential.More info, mostly about an earlier version using a FIDO2 extension instead of a custom CTAP command, can be found in solokeys/solo1#575.
See solokeys/solo1#583 for the authenticator PR.