Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose setting the veins baseDir to the location of the launch config file (e.g.
veins_launchd.xml) by default. It makes more sense to me, because there may be one config file for each scenario, which is where your OSM files should live that get referenced in the config.This should make using multiple SUMO scenarios with the same networks easier, as you do not need to duplicate your networks, or maintain the baseDir XML tags. In my experience the latter became cumbersome in collaboration, because the basedir tag seemed to not work well with relative paths.
For standard projects, there should be no breaking change, as the network file resides in the same directory as the veins launch config by default.