-
Notifications
You must be signed in to change notification settings - Fork 204
[BMC] make bmc-fw-update.py common #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benle7
wants to merge
3
commits into
sonic-net:master
Choose a base branch
from
benle7:benle/feat/bmc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+242
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
Signed-off-by: Ben Levi <belevi@nvidia.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
95061c6 to
f9119cc
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9 tasks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9995df9 to
4260f9a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4260f9a to
f9119cc
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ben Levi <belevi@nvidia.com>
035faba to
f32bdd1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
approved these changes
Dec 30, 2025
Signed-off-by: Ben Levi <belevi@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved BMC firmware update utility from platform-specific location (platform/mellanox/mlnx-bmc-fw-update.py)
to a generic location in sonic-platform-common (src/sonic-platform-common/sonic_platform_base/bmc-fw-update.py).
Motivation and Context
The original BMC firmware update script was Mellanox-specific and located in the platform directory,
preventing other vendors from reusing the functionality.
Moving it to sonic-platform-common creates a standardized BMC firmware update utility
that any vendor can use by implementing their own BMC class following the BMCBase interface.
How Has This Been Tested?
sudo config platform firmware install chassis component BMC fw
Additional Information (Optional)