move XDG_DATA_DIRS environment setup into JS #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bardia Moshiri <bardia@furilabs.com>
sonnyp
requested changes
Apr 18, 2025
Owner
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Did you test this? I'm afraid it doesn't not work. Most likely GLib is reading XDG_DATA_DIRS before it is overriden.
Author
|
then perhaps a better solution is to add a wrapper script and pass XDG_DATA_DIRS that way? |
Owner
|
Sounds like a good idea. Whatever you do please test before having me review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there seems to be some limitations on shebang env expansion.
fixes #170