Skip to content

fix: release build fixes#1246

Merged
WRRicht3r merged 2 commits intodevelopfrom
release-build-fixes
Jan 30, 2026
Merged

fix: release build fixes#1246
WRRicht3r merged 2 commits intodevelopfrom
release-build-fixes

Conversation

@WRRicht3r
Copy link
Contributor

Summary

  • Flow diffing now always subtracts the previous collection from the new set (common/src/main/java/jp/co/soramitsu/common/utils/FlowExt.kt:97), so elements replaced without changing list size are reported in removed, satisfying FlowExtKtTest.testDiffed.
  • The crypto detail formatter keeps high precision for millions while reverting the extreme-trillion case to the short formatter to avoid overlong decimals (common/src/main/java/jp/co/soramitsu/common/utils/NumberFormatters.kt:123). This still preserves the added precision for the other brackets but caps the final test case at three decimals as expected.

Related Issue

Closes # (or) Relates to #

Type of Change

  • feat (new feature)
  • fix (bug fix)
  • refactor (no functional change)
  • chore/build (tooling, CI, deps)
  • docs (README/AGENTS, comments)

Screenshots / Videos

If UI changes, include before/after.

Test Plan

Commands run locally:

./gradlew detektAll
./gradlew runTest
./gradlew :app:lint

Additional checks and scenarios covered:

Risks & Rollout

Potential impact, migrations, or config/secrets required.

Checklist

  • Linked an issue and added a clear description
  • Added/updated tests for changed code (where applicable)
  • Updated docs (README/AGENTS) when behavior or commands changed
  • Ran detektAll, runTest, and :app:lint locally (or via CI)
  • No secrets or local.properties committed

@WRRicht3r
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 718e6e7fe0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@WRRicht3r
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@WRRicht3r WRRicht3r merged commit e7ac245 into develop Jan 30, 2026
@WRRicht3r WRRicht3r deleted the release-build-fixes branch January 30, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants