allow branches #34
Open
allow branches #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
till
commented
Feb 5, 2023
till
commented
- Chore: upgrade go to 1.19
- Chore: update actions
- Update: allow push to certain branches
till
commented
Feb 5, 2023
|
|
||
| env: | ||
| GO_VERSION: 1.18 | ||
| GO_VERSION: 1.19 |
There was a problem hiding this comment.
Mostly updated to be able to use some functions and also, newer is better. :D
| return base != hook.OldRev, nil | ||
| } | ||
|
|
||
| func (r *Receiver) CheckAllowedBranch(hook *HookInfo) error { |
There was a problem hiding this comment.
Made this public so I could add a test. Otherwise, the code in Handle requires a full blown setup with commits and repositories and so on. Not ideal, but hope it's alright.
|
@sosedoff Can you take a look some time? |
|
Yea will review this week. |
sosedoff
requested changes
Mar 2, 2023
This extends MasterOnly and makes it configurable. The idea is to set arbitrary branch names which are allowed to be pushed to and otherwise return an error. Resolves: sosedoff#33
- renamed AllowedBranches to AllowedRefs - use t.Run() in tests
|
@sosedoff this took me a bit longer than expected, can you have a look again? |
Open
|
@sosedoff any interest in this? |
|
Probably, i haven't used the repo myself in quite a bit so getting up to speed will take some time |
|
@sosedoff should I rebase this so we can merge this? Or should I abandon this effort? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.