- 
                Notifications
    You must be signed in to change notification settings 
- Fork 32
Sound processing using FFT #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            Unknown15082
  wants to merge
  35
  commits into
  source-academy:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Unknown15082:master
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Currently eliminating the first and fourth quarter of frequency
playFFT takes in a filter, which for now can be created with lowPassFilter
added minimal buggy example
Added methods to plot time-domain and frequency-domain samples in the plotly module.
Added direct conversions between Sound and FrequencyList in sound_fft - Added definition for FrequencyList type. - Added public methods sound_to_frequency and frequency_to_sound for direct conversion between Sound and FrequencyList types. - Copied the functions next_power_of_2 and sound_to_time_samples from sound module into sound_fft module. Hopefully they can be deleted from sound module eventually. - Added sound_fft/sound_functions.ts to allow sound_fft to use some select functions from sound, as there are still issues with importing.
…raw_sound_time_samples_2d
Renamed `draw_sound_frequency_samples_2d` to `draw_sound_frequency_2d`. The new `draw_sound_frequency_2d` takes in a `FrequencyList` instead of `FrequencySamples`, and plots the full graph (up to sample rate) instead of half. Also removed `draw_sound_time_samples_2d`.
…lude frequency range.
Added frequency augmentation
Fixed issue where long sounds cannot be converted to frequencies
Made low_pass_filter and high_pass_filter symmetric
Merge source-academy/modules into Unknown15082/modules
added points limit to plotly sound drawing functions
added documentation to sound_fft and fixed some in plotly
| I would like a description of the limitations of the current library used, for example, the 5-second limit on FFTs. What is left on the TODO and an estimated time to completion? | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Created a new modules (sound_fft) for sound processing and analysis.
Modified plotly for visualizing sound in time domain and frequency domain.
Introduced a list of APIs for students to create their own sound filter and apply them to sound.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: