feat(search-client): add support for angular v21 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeshamavani
reviewed
Dec 10, 2025
packages/search/README.md
Outdated
| ### Deprecation Notice | ||
|
|
||
| Search-client now supports Angular v20, we will provide support for the older version that is based on Angular v19 till 30th June 2026 . | ||
| Search-client now supports Angular v21, we will provide support for the older version that is based on Angular v20 till 30th September 2026 . |
Contributor
There was a problem hiding this comment.
check the actual angular support
dont give this long support 3-6m is fine
Contributor
Author
There was a problem hiding this comment.
done mam!
| ### Deprecation Notice | ||
|
|
||
| Search-client now supports Angular v20, we will provide support for the older version that is based on Angular v19 till 30th June 2026 . | ||
| Search-client now supports Angular v21, we will provide support for the older version that is based on Angular v20 till 30th September 2026 . |
| "@angular/platform-browser": "^21.0.3", | ||
| "@angular/platform-browser-dynamic": "^21.0.3", | ||
| "@angular/router": "^21.0.3", | ||
| "@sourceloop/search-client": "file:../../packages/search/projects/search-lib/dist", |
Contributor
There was a problem hiding this comment.
make sure to update after release
BREAKING CHANGE: YES GH-50
vaibhavbhalla2505
force-pushed
the
GH-50
branch
from
7fdb2ca to
d1872b7
Compare
yeshamavani
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
YES
Description
This pull request upgrades the Angular dependencies for the search module and related packages from Angular v20 to Angular v21. It also updates the deprecation notice in documentation to reflect this new support window.
Fixes #50
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: