Skip to content

feat(search-client): replace input output decorator technique with signals #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yeshamavani merged 1 commit into from
Dec 19, 2025
Merged

feat(search-client): replace input output decorator technique with signals #60

yeshamavani merged 1 commit into from
Dec 19, 2025

Conversation

@vaibhavbhalla2505
Copy link
Contributor

@vaibhavbhalla2505 vaibhavbhalla2505 commented Dec 18, 2025 •
edited
Loading

Description

Replace input output decorator technique with signals

Fixes #59

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@vaibhavbhalla2505
feat(search-client): replace input output decorator technique with si…
87e9574 
…gnals

replace input output decorator technique with signals

GH-59
@vaibhavbhalla2505 vaibhavbhalla2505 self-assigned this Dec 18, 2025
@vaibhavbhalla2505 vaibhavbhalla2505 added the enhancement New feature or request label Dec 18, 2025
@vaibhavbhalla2505 vaibhavbhalla2505 linked an issue Dec 18, 2025 that may be closed by this pull request
@sourceloop/search-client: introduce signals #59
Closed
@yeshamavani yeshamavani merged commit f55ced9 into search-v19 Dec 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohit-sourcefuse rohit-sourcefuse Awaiting requested review from rohit-sourcefuse

@yeshamavani yeshamavani Awaiting requested review from yeshamavani

Assignees

@vaibhavbhalla2505 vaibhavbhalla2505

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@sourceloop/search-client: introduce signals

3 participants

@vaibhavbhalla2505 @yeshamavani