Skip to content

Fixing port names for Istio service mesh auto config #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Fixing port names for Istio service mesh auto config #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/sourcegraph/templates/frontend/sourcegraph-frontend-internal.Service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ metadata:
name: sourcegraph-frontend-internal
spec:
ports:
- name: http-internal
- name: grpc-internal
port: 80
targetPort: http-internal
targetPort: grpc-internal
selector:
{{- include "sourcegraph.selectorLabels" . | nindent 4 }}
app: sourcegraph-frontend
Expand Down
2 changes: 1 addition & 1 deletion charts/sourcegraph/templates/frontend/sourcegraph-frontend.Deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ spec:
- containerPort: 3080
name: http
- containerPort: 3090
name: http-internal
name: grpc-internal
- containerPort: 6060
name: debug
{{- if not .Values.sourcegraph.localDevMode }}
Expand Down
6 changes: 3 additions & 3 deletions charts/sourcegraph/templates/gitserver/gitserver.Service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ metadata:
spec:
clusterIP: None
ports:
- name: unused
port: 10811
targetPort: 10811
Comment on lines -24 to -26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I think this is safe to remove. If I try to remember the historical context it was some sort of workaround for service discovery in kubernetes before statefulsets existed.

And just for fun, this number comes from me although I see other people added it. "10810" is an old south african programmer joke. When a south african reads it out loud it is "one ou ate one ou". An ou is slang for a guy. So its one guy eating another guy... enjoy your TIL for today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, thank you for the TIL!

- name: grpc
port: 3178
targetPort: 3178
selector:
{{- include "sourcegraph.selectorLabels" . | nindent 4 }}
app: gitserver
Expand Down
6 changes: 3 additions & 3 deletions charts/sourcegraph/templates/gitserver/gitserver.StatefulSet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,17 @@ spec:
# pod because of a failed liveness probe, we give it 2 minutes to start up.
startupProbe:
tcpSocket:
port: rpc
port: grpc
failureThreshold: 120
periodSeconds: 1
livenessProbe:
initialDelaySeconds: 5
tcpSocket:
port: rpc
port: grpc
timeoutSeconds: 5
ports:
- containerPort: 3178
name: rpc
name: grpc
{{- if not .Values.sourcegraph.localDevMode }}
resources:
{{- toYaml .Values.gitserver.resources | nindent 10 }}
Expand Down
Loading