test: Fix on macOS + add macOS to CI #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2025
varungandhi-src
added a commit
that referenced
this pull request
Aug 4, 2025
In PR #177, I added normalization logic inside setTrackedFiles. However, it seems like the other file tracking already must be taking care of passing normalized paths as necessary (hopefully?). In order to minimize the diff size, I'm moving the normalization to the call-site of setTrackedFiles inside the pyright-scip folder. We want to do a merge of upstream changes sooner rather than later, so it'd be good to reduce the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPH-236