Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 32b41e5 | Previous: 585c773 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
35 ms |
45 ms |
0.78 |
Add one schema (100 existing) |
315 ms |
474 ms |
0.66 |
Add one schema (1000 existing) |
3060 ms |
4685 ms |
0.65 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 32b41e5 | Previous: 585c773 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
46 ms |
54 ms |
0.85 |
Add one schema (100 existing) |
446 ms |
473 ms |
0.94 |
Add one schema (1000 existing) |
4141 ms |
4564 ms |
0.91 |
This comment was automatically generated by workflow using github-action-benchmark.
🤖 Augment PR SummarySummary: This PR reduces filesystem I/O overhead during indexing/build caching. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| public: | ||
| Output(std::filesystem::path path) | ||
| : path_{std::filesystem::weakly_canonical(path)} { | ||
| Output(std::filesystem::path path) : path_{path.lexically_normal()} { |
There was a problem hiding this comment.
Output now stores path_ via lexically_normal() without ensuring it’s absolute; track() later walks parent_path() until it equals this->path_, which can become non-terminating at filesystem root if path_ is relative.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| return std::nullopt; | ||
| } | ||
|
|
||
| std::string contents{std::istreambuf_iterator<char>(stream), |
There was a problem hiding this comment.
After building contents from the stream, there’s no check for read errors (e.g., badbit/failbit), so a partial read could yield an incomplete dependency list and make incremental builds incorrectly treat cached dependencies as valid.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com