ci: add tests for php 8.4 #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump min versions
Collaborator
|
Thank you for your contribution. Regarding the tests, I've fixed PHPStan, but there are still some issues with Behat. Some tests are failing during parsing feature files. I'll look into this further before merging this pull request. |
Author
|
ok, thanks |
Collaborator
|
@Chris53897 Can you rebase this PR? Ci is fixed now. |
Author
|
i wil create a new PR. I will get this rebase wrong |
Collaborator
|
Replaced by #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump min versions
"fabpot/goutte": "^3.3 || ^4.0",allows max symfony/dom-crawler from 5 => 6Next steps (seperate PR): support PHP 8.5 and Symfony 8
CI is failing. i have to take a deeper look