Skip to content

Conversation

@lucas-manuel
Copy link
Contributor

YYYY-MM-DD Spark Spell

Forum Post

< Forum post URL >

Dependencies on Sky Core spell

  • List of items (or None)

Addresses

Variable name Address Network Source of truth
PT_SUSDE_MAR26 0x123... mainnet specified in forum post
PT_SUSDE_MAR26_ORACLE 0x456... mainnet provided in TG chat with Pendle

Notes for Reviewers

  • Pay extra attention to: ...
  • Extra feedback wanted on: ...

Conditions for Spell Deployment

  • All spell-specific tests are passing.
  • All E2E tests are passing.
  • All newly deployed addresses have been reviewed and added to the spark-address-registry in a PR that has been merged.
  • All newly deployed addresses have been added to the Immunefi bug bounty program.
  • There is complete test coverage of all changes in the spell, including any relevant edge cases.
  • At least three approvals have been given from reviewers.

Conditions for Spell Handoff to Sky

  • All spells payloads have been deployed and verified on Etherscan.
  • All spell-specific tests are passing (including spell bytecode verification).
  • All E2E tests are passing.
  • Spell caster is passing in CI.
  • At least three approvals have been given from reviewers on deployed spell.
  • Comment from at least three reviewers confirming address of mainnet spell payload.

Conditions for Spell Merge

  • Spell handoff performed to Sky team on Discord.
  • Spell handoff performed to Sky team on Signal.
  • Spell address confirmed to be correct in sky-ecosystem/spells-mainnet repo open PR through comments by at least three reviewers.
  • Sky deployed spell confirmed through a comment in this PR to contain correct Spark payload address by at least three reviewers.

@lucas-manuel lucas-manuel self-assigned this Dec 4, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • master

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-role-testing-20251211

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants