Use EnableInterrupt lib, INPUT_PULLUP, and other little fixes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only changes RG_Rotary_Encoder but most changes probably should apply to RGB_Rotary_Encoder as well but I don't have one to test. - Sets input pins to INPUT_PULLUP - Replaces usage of PinChangeInt lib in favor of EnableInterrupt - Uses faster serial speed - Does LED flash (when turning rotary) even if currently off - Sets initial LED state to x so it doesn't change unexpectantly - Doesn't spam serial when holding button down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only changes RG_Rotary_Encoder but most changes
probably should apply to RGB_Rotary_Encoder as well but
I don't have one to test.