Add an option to use linearToOutputTexel. #210
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a render target is set, threejs automatically change their shaders to output in Linear color space using linearToOutputTexel: https://github.com/mrdoob/three.js/blob/e04b9f7bd7f5b17103339d343168bfab2d6e0ace/src/renderers/WebGLRenderer.js#L2198
However, with Sparkjs, we need to manually set

encodeLinearor else we get a washed out image like this:With this option, we now have the option of setting
sparkRenderer.defaultView.useLinearToOutputTexel = true;and the Spark fragment shader will automatically output in the correct color space the same way that three.js's built-in shaders do.