Open
Conversation
tingley
reviewed
Jul 17, 2018
| } | ||
| } | ||
|
|
||
| protected void segmentTextContainerIfNeeded(TextContainer source) { |
Contributor
There was a problem hiding this comment.
Very minor thing, I think a more generic name like postprocessTextContainer() would be better, since in theory this could be doing other things besides segmentation. However, this is not a real problem.
tingley
approved these changes
Jul 17, 2018
Contributor
tingley
left a comment
tingley
left a comment
There was a problem hiding this comment.
This seems ok. It would be possible to add a testcase to show how custom segmentation in a subclass would produce the correct number of segments written to WS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.