Gh act improvements #137
Open
Gh act improvements #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Still in progress, one more thing left to do. |
karlatec
force-pushed
the
karlatec/ghact
branch
2 times, most recently
from
21c0641 to
186770a
Compare
glimchb
reviewed
Jan 27, 2026
Contributor
|
maybe split in multiple PRs? like cijoe version update separate ? |
Contributor
Author
Sure; doesn't really make much difference to me. |
Add a simple Dockerfile to enable users building a local image which includes Github CLI tool. With this image more workflows can be run locally without the need to temporarily modify the workflows just to install "gh". Signed-off-by: Karol Latecki <karol.latecki@nutanix.com>
Installing nodejs into the images fixes running Github Action workflows locally when using "gh act". Specifically: the parts of the workflows where "container:" is used with Fedora and Freebsd Docker images. Without nodejs available some of the actions (for example - actions/download-artifacts) will not work. Signed-off-by: Karol Latecki <karol.latecki@nutanix.com>
The version with outer double quotes and single inner quotes
works in Github using github-hosted runners, but not locally
using "gh act". "artifact_id" was actually getting exported
as:
'artifact_id={'\''fedora_43'\'':20878294770,'\''freebsd_14'\'':20878294770}'
Gh act JSON parser complains about single quotes and escape
signs, resulting in expressions being evaluated to NIL.
Use double quote for keys in JSON, which fixes the issue for gh act.
Signed-off-by: Karol Latecki <karol.latecki@nutanix.com>
The condition was wrong resulting in shutdown being attepmted for container-based workload in local (gh act) environment. We want to do this only on github-hosted runners and vm-based workloads. Signed-off-by: Karol Latecki <karol.latecki@nutanix.com>
Clear out github.token in case workflow is run locally using "gh act". Using the token results in the artifact being downloaded from Github __every time__ instead of using artifacts cached locally by act (and that's even if offline mode or artifact server path are used). Signed-off-by: Karol Latecki <karol.latecki@nutanix.com>
Use a dynamic value for disk.path based on a variable. The path will be different when running the job using Github-hosted runners and locally using "gh act". Signed-off-by: Karol Latecki <karol.latecki@nutanix.com>
karlatec
force-pushed
the
karlatec/ghact
branch
from
186770a to
1d2bb32
Compare
Contributor
Author
|
@glimchb removed this particular commit from the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series of changes improving running workflows locally using
gh act.Explanations here to avoid going into commit messages:
artifact_idin common tests workflow - there was an issue with quoting whichgh actJSON parser was complaining about. Interestingly - this worked in Github which might suggest different JSON parsers?gh actdisk.pathproblem of .toml file, but decided to keep the version upgrade anyway.