Skip to content

Add job to cancel workflow on failure#139

Open
glimchb wants to merge 1 commit intospdk:mainfrom
glimchb:patch-5
Open

Add job to cancel workflow on failure#139
glimchb wants to merge 1 commit intospdk:mainfrom
glimchb:patch-5

Conversation

@glimchb
Copy link
Contributor

@glimchb glimchb commented Jan 22, 2026

Since HPE rdma tests are quickest (only 15-20 min) if they fail, then fail the entire workflow run, all jobs
to save some free tier runners

Since HPE rdma tests are quickest (only 15-20 min) if they fail,
then fail the entire workflow run, all jobs
to save some free tier runners
Copy link
Contributor

@mhae mhae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@mhae mhae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I remembered that this probably not going to work.

See https://github.com/orgs/community/discussions/26311

I tried implementing the cancel early on when I did the runners and didn't get it to work.

@glimchb
Copy link
Contributor Author

glimchb commented Jan 26, 2026

Actually, I remembered that this probably not going to work.

See https://github.com/orgs/community/discussions/26311

I tried implementing the cancel early on when I did the runners and didn't get it to work.

we cancelling the jobs like this today, see https://github.com/spdk/spdk-ci/blob/main/.github/scripts/parse_gerrit_webhook.sh
@mhae can you specify why you think it is not going to work here ?

with:
path: ./output
name: hpe-job-nvmf-rdma
- name: Cancel all jobs enitre workflow run if this job failed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the same be added to common tests workflow? In this one common tests part failed after a minute or so, but HPE runner was still busy anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It rarely happens. Since how runner only executes a single test. It was true only when how was offline for a bit…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rarely, but still - why keep it busy in such a case? Honestly it was the first failed build I clicked on, so maybe it happens not as rarely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants