Refactor false-positive .sh helper into .py#67
Open
mikeBashStuff wants to merge 2 commits intospdk:mainfrom
Open
Refactor false-positive .sh helper into .py#67mikeBashStuff wants to merge 2 commits intospdk:mainfrom
mikeBashStuff wants to merge 2 commits intospdk:mainfrom
Conversation
karlatec
reviewed
May 21, 2025
Contributor
karlatec
left a comment
karlatec
left a comment
There was a problem hiding this comment.
Overall LGTM, just nits I guess.
mikeBashStuff
force-pushed
the
mb-refactor-python
branch
from
09bf7a4 to
4b57057
Compare
karlatec
approved these changes
May 22, 2025
The amount of json data we need to pass through jq is quite cumbersome to handle, not allowing to easily apply more complex logic against the searched data. Having it under py should be far more straightforward. Signed-off-by: Michal Berger <michal.berger@nutanix.com>
Also, introduce ignore list for parameters that are not deemed as crucial (e.g.: for given workflow). Signed-off-by: Michal Berger <michal.berger@nutanix.com>
mikeBashStuff
force-pushed
the
mb-refactor-python
branch
from
4b57057 to
4701250
Compare
glimchb
suggested changes
Oct 13, 2025
Contributor
glimchb
left a comment
glimchb
left a comment
There was a problem hiding this comment.
i think this script belongs in spdk main repo and not here...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly focuses on moving the .sh into .py. It also changes a bit logic around picking up the latest "build failed" comment by looking at the map of comments per patchset.