refactor: update documentation, docker build process, and JSON RPC handling#44
refactor: update documentation, docker build process, and JSON RPC handling#44idoyo7 wants to merge 3 commits intospdk:masterfrom
Conversation
|
this is my first time editting opensource and making PR. However, I'd like to emphasize that the JSON RPC type definition must be updated, as the current version prevents NVMe devices from being created. This PR was tested and verified on SPDK v24.05, K8S v1.28, and Ubuntu 22.04." |
|
Hi @idoyo! Thank you for your submission and the detailed explanations! Unfortunately, SPDK does not take pull requests via GitHub. Please see https://spdk.io/development for how to push patches to the SPDK Gerrit instance for review. If you have found issues with the current implementation, please also consider submitting an issue to the SPDK GitHub database, https://github.com/spdk/spdk/issues. Then you can add comments to that issue with links to the Gerrit URLs that will get generated for your patches. Tagging @cyb70289 and @askervin for their attention. Thanks, Jim |
Changes Included in This Pull Request
Documentation Update for Multi-Node Setup
multi-node.mddocumentation to enhance clarity and ensure accuracy, reflecting the latest operational procedures for setting up multiple nodes.Docker Image Build Process Enhancement
Refinement of JSON RPC Parameter Types
jsonrpc.goto improve compatibility and robustness. This update makes our JSON RPC calls more consistent and reliable across different platforms and configurations.Rationale Behind Changes
These changes aim to improve the usability and stability of our system. The updates to the documentation make it easier for new users to get started with multi-node setups, while the Docker and JSON RPC updates enhance the overall development environment and system reliability.
Testing and Validation
I welcome any feedback or suggestions on these changes and look forward to your reviews. Thank you for considering this pull request!