-
Notifications
You must be signed in to change notification settings - Fork 42
Bump dompurify, handsontable, and @testing-library/react #7396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fix missing HotTable type
| callback: handleClickDisambiguate, | ||
| }, | ||
| ['separator_1' as 'undo']: '---------', | ||
| separator_1: '---------', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['separator_1' as 'undo'] was showing me an error, so I changed it to just separator_1.
It was originally done to avoid a type error in the first place 3d3eb1d, but it seems to be fine now, I hope.
bhumikaguptaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make sure no new errors occur when adding and modifying data on the spreadsheet.
- Make sure scrolling/navigation works as expected when you have a lot of rows or columns.
- Make sure you can successfully validate and upload a dataset.
Looks good!
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make sure no new errors occur when adding and modifying data on the spreadsheet.
- Make sure scrolling/navigation works as expected when you have a lot of rows or columns.
- Make sure you can successfully validate and upload a dataset.
Scrolling behavior is a bit weird and rows/columns seem to constantly change size.
Main:
09-10_14.54.mp4
Issue branch:
09-10_14.55.mp4
|
@emenslin I tweaked a couple of things to make rows load more reliably and to make columns resize correctly (Maybe better than it was before). Dev note: |
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make sure no new errors occur when adding and modifying data on the spreadsheet.
- Make sure scrolling/navigation works as expected when you have a lot of rows or columns. (Like this dataset: FishTissueData.tsv )
- Make sure workbench performance/speed when scrolling isn't worse than in main.
- Make sure you can successfully validate and upload a dataset.
Scrolling behavior is now lagging and sometimes does not render the rows.
Issue branch:
09-22_12.20.mp4
Main:
09-22_12.21.mp4
|
Hmm okay after some consideration it might be best to wait for handsontable to possibly address some of the rendering issues. It looks like autoColumnSize is broken on virtualized tables, and trying to manually fix it makes it laggy so I'm not sure there's a good solution right now. This PR can be repurposed once a new update is out. |
Fixes #7322
Some types changed so some minor code changes were needed.
Upgraded @testing-library/react too because multiple tests were suddenly failing (because user events weren't being automatically wrapped in act() ).
Checklist
self-explanatory (or properly documented)
Testing instructions