Skip to content

Conversation

@Iwantexpresso
Copy link

@Iwantexpresso Iwantexpresso commented Oct 29, 2025

Fixes #4921

Fixed issue that caused the deletion of a workbench dataset through the dataset meta menu to always redirect the user away from their current page, regardless if they were on the deleted dataset or not. You should only be redirected if the dataset you deleted is the dataset you were on

Previous behavior:

prev.mov

Fixed behavior:

Screen.Recording.2025-10-29.at.10.28.01.AM.mov

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • select any page that is not workbench then try to delete a workbench dataset through the dataset meta menu. Try these on at least 2 more different pages.
  • Select a workbench dataset, then try to delete the dataset you're currently on. This should redirect you to the Home page

Note: ignore the current failing tests, git guardian is being mean. Tests have been verified locally.

Fixed the redirection issues, now attempting to solve new issue that does not redirect the user away from an open dataset they've just deleted through the DatasetMeta Delete button
Triggered by 66983cb on branch refs/heads/issue-4921
Triggered by c8a956c on branch refs/heads/issue-4921
…le event unsubscription while not on Workbench
@Iwantexpresso Iwantexpresso changed the title Issue 4921 FIXED: Deleting a dataset navigates you away form current page. Oct 29, 2025
@Iwantexpresso Iwantexpresso requested review from a team and melton-jason October 29, 2025 15:43
@Iwantexpresso Iwantexpresso marked this pull request as ready for review October 29, 2025 15:44
@gitguardian
Copy link

gitguardian bot commented Oct 29, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
21648217 Triggered Generic Password dbb1e96 .env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gitguardian
Copy link

gitguardian bot commented Oct 29, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Triggered by dbb1e96 on branch refs/heads/issue-4921
@grantfitzsimmons grantfitzsimmons changed the title FIXED: Deleting a dataset navigates you away form current page. fix(workbench): Deleting a dataset navigates you away form current page. Oct 30, 2025
@CarolineDenis CarolineDenis added this to the 7.12.0 milestone Nov 3, 2025
@CarolineDenis CarolineDenis requested a review from a team November 3, 2025 21:40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.DS_Store is a macOS Finder cache file; it doesn’t belong in the repo. The OS drops them in directories you view to remember window layout, icon positions, sort order, etc. They’re harmless but annoying in repos. You can ignore it while pushing the code.

Copy link
Member

@acwhite211 acwhite211 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, add this line to your .gitignore file.

*.DS_Store

That will avoid this issue in the future.
Make sure to delete this .DS_Store file before merging this PR into main

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright thank you! I did not notice that and my apologies.

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • select any page that is not workbench then try to delete a workbench dataset through the dataset meta menu. Try these on at least 2 more different pages.
  • Select a workbench dataset, then try to delete the dataset you're currently on. This should redirect you to the Home page

Looks good, only takes you to the homepage when you're on the page with the dataset you're deleting!

@emenslin emenslin requested a review from a team November 7, 2025 20:44
@CarolineDenis CarolineDenis removed the request for review from melton-jason November 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Deleting a data set takes you back to the home page

6 participants