-
Notifications
You must be signed in to change notification settings - Fork 42
Fix : tree rank picklist validation after async data loads #7524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Iwantexpresso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
open an existing non-root tree node, and confirm the Level field stays valid and Save button is not red anymore, other buttons stays enabled without re-selecting the rank.
-
just tested it and it looks good!
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@Gitesh307, do you know when this code was changed and why? |
The change was introduced when I added the fix to disable manual typing in tree-level rank picklists issue #4985. That fix unintentionally treated _treeLevelComboBox like the others, which moved it to a simple dropdown and broke validation that depends on async data loading. So the condition was updated to exclude _treeLevelComboBox, letting it keep AutoComplete behavior and resolving the validation issue in #7524 . |
Triggered by d6423fc on branch refs/heads/issue-7511
|
The PR now initializes as valid and Save is enabled without allowing manual typing. Both validation and non-typeable behavior for tree level rank picklist (issue-4985) are intact. |

Fixes #7511
This PR restores the tree level picklist to its pre-regression behavior so editing existing tree nodes no longer triggers the browser’s “Please select an item in the list” error.
Checklist
self-explanatory (or properly documented)
Testing instructions