Fix blank_nulls wrapping numeric CatalogNumber cast instead of raw column #7533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acwhite211
requested review from
a team,
alesan99,
grantfitzsimmons and
melton-jason
Gitesh307
approved these changes
Nov 5, 2025
Contributor
Gitesh307
left a comment
Gitesh307
left a comment
There was a problem hiding this comment.
Looks good! Verified on KU Birds, formatted catalog numbers now keep leading zeros in query results.
Iwantexpresso
requested changes
Nov 5, 2025
Iwantexpresso
left a comment
Iwantexpresso
left a comment
There was a problem hiding this comment.
Use the KUBrids database
Open the QB for CO and run a query with catalog number formatted.
- See that the query results for the formatted catalog number have leading zeros.
Tested on KuBirds as requested, and sd_paleo It looks like the issue has persisted, I also tested it on bohart_entomology's pinned insects collection and it is at least working fine there.
github-project-automation
bot
moved this from 📋Back Log
to Dev Attention Needed
in General Tester Board
Member
Author
|
Couldn't recreate the issue on sd_paleo or KUBirds for this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7510
Fixes issue found in v7.11.3 testing where on the KUBirds database, the CO catalog number formatted field was displaying results as numbers without leading zeros, like
1instead of this000000001.The issue introduced by recent refactoring of query-building defaults where the generated SQL for CatalogNumber fields wrapped the numeric cast expression inside IFNULL(...) rather than the raw column.
The ObjectFormatter.make_expr() method always wrapped the formatted expression in blank_nulls(...), even after _fieldformat() applied the numeric cast for CatalogNumber. After refactoring to use a fresh DefaultQueryFormatterProps(), the numeric_catalog_number flag was applied earlier, allowing the change in the generated SQL.
Here is the formatted catalog number in the query before:
And here it is after the changes in this PR:
Checklist
self-explanatory (or properly documented)
Testing instructions