Fix: Cloning now correctly copies COA values when default COA creation is enabled.

specifyweb/frontend/js_src/jest.config.ts

@@ -115,7 +115,7 @@ const config: Config.InitialOptions = {
   moduleNameMapper: {
     '\\.(jpg|jpeg|png|webp|svg|ttf|webm)$':
       '<rootDir>/lib/tests/__mocks__/fileMock.ts',
-      '^react-dom/server$': 'react-dom/server.node',
+    '^react-dom/server$': 'react-dom/server.node',
     '\\.(css)$': '<rootDir>/lib/tests/__mocks__/styleFileMock.ts',
   },
 

specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx

@@ -109,7 +109,8 @@ export function RecordSetAttachments<SCHEMA extends AnySchema>({
 
   const isComplete = fetchedCount.current === recordCount;
 
-  const [showCreateRecordSetDialog, setShowCreateRecordSetDialog] = React.useState(false);
+  const [showCreateRecordSetDialog, setShowCreateRecordSetDialog] =
+    React.useState(false);
 
   return (
     <>
@@ -133,16 +134,17 @@ export function RecordSetAttachments<SCHEMA extends AnySchema>({
               <Button.Info
                 title={attachmentsText.downloadAllDescription()}
                 onClick={(): void =>
-                  (recordSetId === undefined && !isComplete) ? 
-                  setShowCreateRecordSetDialog(true)
-                  :
-                  loading(
-                    downloadAllAttachments(
-                      (recordSetId !== undefined && !isComplete) ? [] : attachmentsRef.current?.attachments ?? [],
-                      name,
-                      recordSetId,
-                    )
-                  )
+                  recordSetId === undefined && !isComplete
+                    ? setShowCreateRecordSetDialog(true)
+                    : loading(
+                        downloadAllAttachments(
+                          recordSetId !== undefined && !isComplete
+                            ? []
+                            : (attachmentsRef.current?.attachments ?? []),
+                          name,
+                          recordSetId
+                        )
+                      )
                 }
               >
                 {attachmentsText.downloadAll()}
@@ -157,15 +159,15 @@ export function RecordSetAttachments<SCHEMA extends AnySchema>({
           header={
             attachmentsRef.current?.attachments === undefined
               ? attachmentsText.attachments()
-              : (isComplete ? 
-                commonText.countLine({
-                  resource: attachmentsText.attachments(),
-                  count: attachmentsRef.current.attachments.length
-                }) : 
-                commonText.countLineOrMore({
-                  resource: attachmentsText.attachments(),
-                  count: attachmentsRef.current.attachments.length
-                }))
+              : isComplete
+                ? commonText.countLine({
+                    resource: attachmentsText.attachments(),
+                    count: attachmentsRef.current.attachments.length,
+                  })
+                : commonText.countLineOrMore({
+                    resource: attachmentsText.attachments(),
+                    count: attachmentsRef.current.attachments.length,
+                  })
           }
           onClose={handleHideAttachments}
         >
@@ -215,13 +217,11 @@ function CreateRecordSetDialog({
 }): JSX.Element {
   return (
     <Dialog
-      buttons={
-          <Button.DialogClose>{commonText.close()}</Button.DialogClose>
-      }
+      buttons={<Button.DialogClose>{commonText.close()}</Button.DialogClose>}
       header={attachmentsText.downloadAll()}
       onClose={onClose}
     >
       {attachmentsText.createRecordSetToDownloadAll()}
     </Dialog>
   );
-}
+}

specifyweb/frontend/js_src/lib/components/BatchEdit/index.tsx

@@ -247,7 +247,6 @@ const containsSystemTables = (queryFieldSpec: QueryFieldSpec) => {
   return Boolean(baseIsBlocked || pathHasBlockedSystem);
 };
 
-
 const hasHierarchyBaseTable = (queryFieldSpec: QueryFieldSpec) =>
   Object.keys(schema.domainLevelIds).includes(
     queryFieldSpec.baseTable.name.toLowerCase() as 'collection'

specifyweb/frontend/js_src/lib/components/DataModel/businessRules.ts

@@ -7,7 +7,11 @@ import { softFail } from '../Errors/Crash';
 import { isTreeResource } from '../InitialContext/treeRanks';
 import type { BusinessRuleDefs } from './businessRuleDefs';
 import { businessRuleDefs } from './businessRuleDefs';
-import { backboneFieldSeparator, backendFilter, djangoLookupSeparator } from './helpers';
+import {
+  backboneFieldSeparator,
+  backendFilter,
+  djangoLookupSeparator,
+} from './helpers';
 import type {
   AnySchema,
   AnyTree,
@@ -316,10 +320,7 @@ export class BusinessRuleManager<SCHEMA extends AnySchema> {
         )
       );
 
-    const stringValuesAreEqual = (
-      left: string,
-      right: string
-    ): boolean =>
+    const stringValuesAreEqual = (left: string, right: string): boolean =>
       rule.isDatabaseConstraint
         ? left.localeCompare(right, undefined, { sensitivity: 'accent' }) === 0
         : left === right;

specifyweb/frontend/js_src/lib/components/DataModel/scoping.ts

@@ -39,7 +39,9 @@ export function initializeResource(resource: SpecifyResource<AnySchema>): void {
 
   if (
     getCollectionPref('CO_CREATE_COA', schema.domainLevelIds.collection) &&
-    hasTablePermission('CollectionObjectAttribute', 'create')
+    hasTablePermission('CollectionObjectAttribute', 'create') &&
+    resource.createdBy !== 'clone' &&
+    collectionObject.get('collectionObjectAttribute') == null
   ) {
     const attribute = new tables.CollectionObjectAttribute.Resource();
     attribute.placeInSameHierarchy(collectionObject);