feat(rhino): Textures POC #1194
Draft
+49
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
reviewed
Nov 18, 2025
| return null; | ||
| } | ||
|
|
||
| byte[] bytes = File.ReadAllBytes(path); |
Contributor
There was a problem hiding this comment.
Can we have some limit to prevent abuse of the objects store please?
Member
Author
There was a problem hiding this comment.
It's a good topic for discussion.
The server enforces a 100MB limit on a single object size.
We have very similar limits setup for brepx.
I can consider artificially reducing the limit for textures client side to something more reasonable like 10MB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/specklesystems/speckle-server-internal/tree/alex/CNX-2801-textures
Before this can be merged:
RenderMaterialonRenderMaterialProxy