Lara-dsl-deprecation Checkpoint 5

[lm-sousa]

NOT TO BE MERGED. FOR REVIEW PURPOSES ONLY. THIS IS PART OF A STACKED DIFF.

[Copilot]

Pull Request Overview

This PR focuses on updating test files to reflect fixes in the production code, primarily replacing assertions that documented bugs with assertions that verify correct behavior. The changes address previously documented issues related to null handling, validation, thread safety, and interface hierarchy support.

Key Changes:

• Updated test assertions to expect correct behavior instead of buggy behavior
• Removed "BUG" comments and updated corresponding assertions
• Enhanced thread safety in test utilities (CopyOnWriteArrayList)
• Fixed test expectations for null handling and validation

Reviewed Changes

Copilot reviewed 297 out of 507 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
TextAreaHandlerTest.java	Updated exception handling test to capture throwables on EDT without uncaught exceptions
LoggingOutputStreamTest.java	Changed to thread-safe CopyOnWriteArrayList for concurrent logging tests
LogSourceInfoTest.java	Refactored setup/teardown to use factory defaults instead of copying original state
ThreadSafeLazyTest.java	Updated null supplier test to expect NullPointerException
LazyTest.java	Updated null supplier tests to expect NullPointerException with proper messages
LazyStringTest.java	Fixed null value handling test to expect "null" string instead of null
JobUtilsTest.java	Updated interrupted job tests to expect correct return values and behavior
JobTest.java	Fixed exception handling test to expect correct interrupted flag propagation
JobProgressTest.java	Updated nextMessage tests to handle gracefully instead of throwing exceptions
InputModeTest.java	Updated null validation tests to expect IllegalArgumentException with messages
ResourceCollectionTest.java	Changed getter method calls from getId()/getResources() to id()/resources()
InputFilesTest.java	Changed field access from direct field access to accessor methods
GraphSerializableTest.java	Changed field access to accessor methods for serializable fields
EventNotifierTest.java	Updated unsafe notifier implementation to demonstrate null rejection
ActionsMapTest.java	Updated null action tests to expect NullPointerException
CsvWriterTest.java	Fixed formula range calculation tests and empty initialization handling
PushingQueueTest.java	Updated toString test to include null in expected output
ChannelConsumerTest.java	Re-enabled timeout edge cases test
MultiFunctionTest.java	Updated default value tests to expect correct behavior and fluent interface
FunctionClassMapTest.java	Fixed null default function return handling
ClassSetTest.java	Updated null handling and interface hierarchy tests
ClassMapTest.java	Fixed null value handling and null class validation
RegisterUtilsTest.java	Updated null input handling and multiple underscore parsing
JumpDetectorTest.java	Added logic to distinguish between _TAKEN and _NOT_TAKEN instructions
DelaySlotBranchCorrectorTest.java	Updated jump handling tests and added nested jump test
ArithmeticResult32Test.java	Changed field access to accessor methods
SpecsSystemTest.java	Removed duplicate test methods and changed field visibility
SpecsSwingTest.java	Added headless environment guards and mocking for file browser tests
SpecsNumbersTest.java	Updated null input test to expect NullPointerException
SpecsCheckTest.java	Added @SuppressWarnings for deprecated checkNotNull usage
SpecsAsmTest.java	Changed field access to accessor methods
XmlNodes.java	Added null checks in factory and utility methods
XmlNode.java	Enhanced getText/setText with null handling and empty text support
XmlGenericNode.java	Added null validation in constructor
XmlElement.java	Added null validation for attribute operations
XmlDocument.java	Added null validation and error handling for factory methods
MemProgressBarUpdater.java	Added null check and EDT-safe initialization
HeapWindow.java	Added headless environment support
HeapBar.java	Added null checks for timer cancellation
Table.java	Replaced manual map initialization with computeIfAbsent
StringSlice.java	Applied pattern matching for instanceof
StringList.java	Simplified equals method and improved decode/encode
StringLines.java	Replaced .length() > 0 with !isEmpty()
SpecsThreadLocal.java	Replaced Preconditions with Objects.requireNonNull
ScheduledLinesBuilder.java	Fixed toString for empty scheduledLines
ProgressCounter.java	Added validation, documentation, and default constructor
PrintOnce.java	Changed to thread-safe ConcurrentHashMap.newKeySet()
PersistenceFormat.java	Added null validation for file and class parameters
PatternDetector.java	Added null-safe equals check
NullStringBuilder.java	Added toString override
MemoryProfiler.java	Added lifecycle management and proper thread control
LineStream.java	Removed unnecessary try-catch, added null check for lastLines
LastUsedItems.java	Added null-safe equals and Optional.ofNullable
JarPath.java	Added exception handling for invalid paths
ClassMapper.java	Added null validation and recursive interface mapping
CachedValue.java	Enhanced thread safety with volatile and synchronization
CachedItems.java	Improved thread safety with atomic counters and computeIfAbsent
BuilderWithIndentation.java	Added null validation and optimized indentation
BufferedStringBuilder.java	Added null validation, toString, and persisted content cache
AverageType.java	Enhanced geometric mean calculation with overflow protection
OutputType.java	Swapped enum order to match conventional stdout/stderr ordering
DebugBufferedReader.java	Added null handling and improved debug output
ProcessOutputAsString.java	Fixed null value handling in getOutput
ProcessOutput.java	Replaced string concatenation with StringBuilder.append
StreamToString.java	Replaced System.getProperty with System.lineSeparator
StreamCatcher.java	Replaced System.getProperty with System.lineSeparator
MapModelV2.java	Added @serial annotations
MapModel.java	Added bounds validation and improved setValueAt
GenericActionListener.java	Added @serial annotation
StringSplitterRules.java	Changed method calls to use record accessor methods
StringSplitter.java	Changed method calls to use record accessor methods
StringSliceWithSplit.java	Changed method calls to use record accessor methods
SplitResult.java	Converted class to record
StringParsersLegacy.java	Changed method calls to use record accessor methods
StringParsers.java	Changed Arrays.asList to Collections.singletonList
StringParser.java	Fixed trim detection logic to use object comparison
ParserResult.java	Converted class to record with Optional.ofNullable
ReporterUtils.java	Replaced Preconditions with Objects.requireNonNull
Reporter.java	Added synchronization to default methods
GenericWebResourceProvider.java	Converted class to record
GenericResource.java	Converted class to record
GenericFileResourceProvider.java	Added null validation and fixed isVersioned logic
CachedStringProvider.java	Improved Optional handling
WebResourceProvider.java	Changed method names to record accessor style
StringProvider.java	Added null validation
Resources.java	Added null validation
ResourceProvider.java	Simplified list operations with Collections.addAll
ProvidersSupport.java	Replaced Preconditions with Objects.requireNonNull
FileResourceProvider.java	Changed method name and improved null handling
FileResourceManager.java	Improved Optional handling
SpecsProperty.java	Added headless check for heap window
SpecsProperties.java	Improved property access with containsKey
CommentParser.java	Improved Optional handling
PragmaRule.java	Simplified string joining
PragmaMacroRule.java	Simplified string joining
MultiLineCommentRule.java	Simplified string joining
GenericTextElement.java	Converted class to record
ArgumentsParser.java	Replaced Arrays.asList with List.of
LineParser.java	Replaced .length() == 0 with !isEmpty()
GenericCodec.java	Added @serial annotation
TreeNode.java	Replaced Preconditions with Objects.requireNonNull
ATreeNode.java	Replaced SpecsCheck/Preconditions with Objects.requireNonNull
settings.gradle	Fixed includeBuild path

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[joaobispo]

SpecsLogs.warn()

[lm-sousa]

There were 81 instances of SpecsLogs.getLogger().warning(...). I assumed you wanted all of them changed and so I did so.

[joaobispo]

I don't think this is equivalent, the isVersioned flag IIRC is related to the name of the resource (i.e., if it is expected that the version appears in the name). This is different from providing a version, which will be used to check if a new version should be used (regardless if the version is supposed to be in the name or not)

[lm-sousa]

Doesn't the WebResourceProvider force the version name to be in the file name?

[joaobispo]

Looking closely at the code, this variable might not even be needed. It is only used in one place, inside GenericFileResourceProvider:

    @Override
    public FileResourceProvider createResourceVersion(String version) {
        if (isVersioned) {
            throw new NotImplementedException("Not implemented when file is versioned");
        }

        // Create new versioned file
        return newInstance(existingFile, version);
}

What the change in the code is doing is preventing a versioned file to change version?

[lm-sousa]

The changed was introduced as a fix to:

Bug 7: GenericFileResourceProvider Always Sets isVersioned to False

Location: pt.up.fe.specs.util.providers.impl.GenericFileResourceProvider.newInstance() method
Issue: The newInstance method always passes false for the isVersioned parameter regardless of whether a version is provided. This means the createResourceVersion method never throws NotImplementedException even for versioned providers.
Impact: Versioned providers can have their versions changed when they shouldn't be able to, violating the intended behavior documented in the createResourceVersion method.
Current Behavior: All providers are marked as non-versioned, allowing version changes on any provider.
Expected Behavior: Providers created with a version should be marked as versioned and should throw NotImplementedException when createResourceVersion is called.
Recommendation: Fix the newInstance method to set isVersioned to true when a version is provided.