AddressSynchronizer: invalidate balance cache on spv #10396
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This loop seems like a leftover that is not useful anymore, clearing the cache once has the same effect.
There was a race incorrectly counting transactions with one confirmations to the unconfirmed balance instead of the confirmed balance. This happened because the balance cache of AddressSynchronizer got invalidated after `on_event_blockchain_updated` and then again after `receive_history_callback`->`add_transaction`, however when calling `AddressSynchronizer.get_balance()` before the tx got spv verified the height would still be counted as 0 (unconfirmed), populating the balance cache again with the unconfirmed balance. I noticed this only on QML due to timing differences to Qt. Invalidating the cache in `AddressSynchronizer.add_verified_tx()` after the tx got verified causes the balance to get recalculated and shown correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race incorrectly counting transactions with one
confirmations to the unconfirmed balance instead of the confirmed
balance (in the pie chart and the qml total balance shown above the history).
This happened because the balance cache of AddressSynchronizer got
invalidated after
on_event_blockchain_updatedand then again afterreceive_history_callback->add_transaction, however when callingAddressSynchronizer.get_balance()before the tx got spv verified theheight would still be counted as 0 (unconfirmed), populating the balance
cache again with the unconfirmed balance.
I noticed this only on QML due to timing differences to Qt.
Invalidating the cache in
AddressSynchronizer.add_verified_tx()afterthe tx got verified causes the balance to get recalculated and shown
correctly.