fix(watch): prevent memory leak by adding StopWatch method#2039
Open
LuSrackhall wants to merge 1 commit intospf13:masterfrom
Open
fix(watch): prevent memory leak by adding StopWatch method#2039LuSrackhall wants to merge 1 commit intospf13:masterfrom
LuSrackhall wants to merge 1 commit intospf13:masterfrom
Conversation
Add an explicit mechanism to stop the configuration watcher and release resources. Previously, the WatchConfig method started a goroutine that would only exit if the config file was removed or a watcher error occurred. This caused a memory leak when the Viper instance was no longer in use because the goroutine held a reference to it. Changes: - Added a `stopCh` channel to the Viper struct to signal the watcher goroutine to exit - Added a public method `StopWatch()` that closes the `stopCh` channel to stop the watcher - Modified the goroutine in `WatchConfig` to listen to `stopCh` and exit when closed - Added test case to verify goroutine termination and resource cleanup This allows the Viper instance to be garbage collected when there are no external references and StopWatch is called. Fixes spf13#2038
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit mechanism to stop the configuration watcher and release resources.
Previously, the WatchConfig method started a goroutine that would only exit if the config file was removed or a watcher error occurred. This caused a memory leak when the Viper instance was no longer in use because the goroutine held a reference to it.
Changes:
stopChchannel to the Viper struct to signal the watcher goroutine to exitStopWatch()that closes thestopChchannel to stop the watcherWatchConfigto listen tostopChand exit when closedThis allows the Viper instance to be garbage collected when there are no external references and StopWatch is called.
Fixes #2038