Skip to content

Use StringReplacer interface instead of strings.replacer#2087

Open
thespags wants to merge 2 commits intospf13:masterfrom
thespags:master
Open

Use StringReplacer interface instead of strings.replacer#2087
thespags wants to merge 2 commits intospf13:masterfrom
thespags:master

Conversation

@thespags
Copy link

There exists StringReplacer already, but it's not available on a specific viper instance, only the singleton instance.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2025

CLA assistant check
All committers have signed the CLA.

@thespags
Copy link
Author

Hi @sagikazarmark, is this something non-controversial to merge? There's a StringReplacer interface created for viper, that's used for the singleton instance, but on the viper call itself it requires the struct *strings.Replacer, which is harder to implement a matcher for.

@thespags
Copy link
Author

thespags commented Jan 13, 2026

Thanks for your other approval. Hi again @sagikazarmark , I was wondering if we could get this change in as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants