Special formatting of ranges as choices instead of listing entries#69
Open
jonrebm wants to merge 1 commit intosphinx-doc:mainfrom
Open
Special formatting of ranges as choices instead of listing entries#69jonrebm wants to merge 1 commit intosphinx-doc:mainfrom
jonrebm wants to merge 1 commit intosphinx-doc:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage ? 46.97%
=======================================
Files ? 12
Lines ? 960
Branches ? 205
=======================================
Hits ? 451
Misses ? 468
Partials ? 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1f52d04 to
8f7e4e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using an argument with
choices=range(0, 256). This leads to a long list of all the options in the generated documentation. This patch reduces code duplication by moving choice formatting to a separate function invoked for action groups, positional arguments, and optional arguments.The only functional change is that for objects of type
rangewith a step of one, formatting is changed from "Possible choices: 0, 1, 2 [...]" to "Value range: 0 to 256"