Add types and RPCs for WIT-SVID #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
MarcosDY,
amartinezfayo,
evan2645 and
rturner3
as code owners
sorindumitru
force-pushed
the
wit-svid
branch
from
4cd6952 to
b58591a
Compare
sorindumitru
force-pushed
the
wit-svid
branch
from
b58591a to
1db03ba
Compare
arndt-s
reviewed
Oct 27, 2025
| // Required. SPIFFE ID of the JWT-SVID. | ||
| spire.api.types.SPIFFEID id = 1; | ||
|
|
||
| // Required. Public key for the cnf claim. |
There was a problem hiding this comment.
This should specify the encoding. I propose either JWK incl. private key or ASN1 DER.
arndt-s
reviewed
Oct 27, 2025
| // Required. The entry ID for the identity being requested. | ||
| string entry_id = 1; | ||
|
|
||
| // Required. The ASN.1 DER encoded Certificate Signing Request (CSR). The |
There was a problem hiding this comment.
I don't think a CSR should be required for requesting a WIT. Similar to comment above I propose to just require the key itself (JWK or ASN DER)
This contains the types and RPCs for some basic functionality for WIT-SVIDs to work. Extra functionality is required for UpstreamAuthority spire to function and for tainting and revoking keys. Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
force-pushed
the
wit-svid
branch
2 times, most recently
from
1d963a2 to
192769c
Compare
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
force-pushed
the
wit-svid
branch
from
192769c to
64018b1
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the types and RPCs for some basic functionality for WIT-SVIDs to work. Extra functionality is required for UpstreamAuthority spire to function and for tainting and revoking keys.