Python 3 compatibility. #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Author
|
@splitbrain Could you finish it? |
Author
|
@splitbrain Do you read these? |
szepeviktor
added a commit
to szepeviktor/Watcher-splitbrain
that referenced
this pull request
Feb 25, 2015
Good morning! Do you maintain this fork? This graph contains so much forks: https://github.com/gregghz/Watcher/network As I see none of them has open issues. Please tell about it. Which should I use? I am trying to make it Python 3 compatible: splitbrain#6
Owner
|
Applying this would break Python 2 compatibility, right? Since I'm running this on a system with python 2 only, I need the python 2 compatibility. If there's a way to be compatible with both, I'm open for suggestions. |
Author
|
I think it won't break. |
Author
|
getzze#2 |
Author
|
@getzze and merge PEP3143 related commits (maybe) |
|
my fork is actually quite different from this version. And it's almost python3 compatible I would say |
|
#18 See my pull request that is compatible with both Python 2.7.6 + and 3.4+ (at least as far as I tested :) ) @szepeviktor @splitbrain @getzze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you also enable Issues