adding aspect ratio param #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We find ourselves having a lot of archive (digitized) videos that are not in 16:9 but still should be responsive and full width.
Not sure if it's the most elegant solution, but I added parser that looks for a parameter like "4:3" or "16:9" and adds the matching aspect-ratio definition to the styles of the iframe (and unset the height, if there's an aspect ration definition)
I also added a coercion (back) to string to the condition in the sizeToStyle function as this was resulting in "width: 100%px"
let me know if you find this useful or think it needs further improvement.