Skip to content

Conversation

@aferch
Copy link

@aferch aferch commented Sep 2, 2025

Replace deprecated spacing tokens with current design system spacing tokens

Issue number:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Effort from Splunk UI Design System team to replace themes1.x deprecated token usage.

Changes

  • Updated spacing token references from deprecated naming to current naming convention
  • Simplified CSS by removing unnecessary calc() wrapper in GlobalStyles.ts
  • Files updated: EntityPage.tsx and GlobalStyles.ts

User experience

none

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

Replace deprecated spacing tokens with current design system spacing tokens
@aferch aferch requested a review from a team as a code owner September 2, 2025 19:43
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

All contributors have NOT signed the COC Document


I have read the Code of Conduct and I hereby accept the Terms


3 out of 4 committers have signed the CLA.
✅ (srv-rr-github-token)[https://github.com/srv-rr-github-token]
✅ (hetangmodi-crest)[https://github.com/hetangmodi-crest]
✅ (kkedziak-splunk)[https://github.com/kkedziak-splunk]
@aferch
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@pull-request-size pull-request-size bot added size/L and removed size/XS labels Sep 2, 2025
@kkedziak-splunk
Copy link
Contributor

Hi @aferch, could you sign the CLA by writing: "I have read the CLA Document and I hereby accept the CLA"

And: "I have read the Code of Conduct and I hereby accept the Terms"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants