-
Notifications
You must be signed in to change notification settings - Fork 127
style: fix code format with gofmt #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
6bff0ba to
ed695e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to fix code formatting issues using gofmt, primarily addressing import ordering and whitespace inconsistencies. However, it also includes undocumented dependency version updates that should ideally be separated into a different PR.
Key Changes:
- Reordered imports in test files to follow Go's standard formatting (placing dot imports after named imports from the same package group)
- Fixed trailing whitespace and comment alignment in source files
- Updated several dependencies (ginkgo, gomega, logr, protobuf) and added new indirect dependencies
Reviewed changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/smoke_test.go | Reordered ginkgo imports per gofmt standards |
| test/smartstore/smartstore_test.go | Reordered ginkgo imports per gofmt standards |
| test/smartstore/manager_smartstore_test.go | Reordered ginkgo imports per gofmt standards |
| test/secret/secret_s1_test.go | Reordered ginkgo imports per gofmt standards |
| test/secret/secret_m4_test.go | Reordered ginkgo imports per gofmt standards |
| test/secret/secret_c3_test.go | Reordered ginkgo imports per gofmt standards |
| test/secret/manager_secret_s1_test.go | Reordered ginkgo imports per gofmt standards |
| test/secret/manager_secret_m4_test.go | Reordered ginkgo imports per gofmt standards |
| pkg/splunk/enterprise/util.go | Removed trailing whitespace on blank line |
| pkg/splunk/enterprise/afwscheduler_test.go | Aligned inline comments for consistency |
| cmd/main.go | Fixed whitespace alignment and removed trailing space from TODO comment |
| go.mod | Updated dependency versions (should be separated from formatting changes) |
| go.sum | Updated checksums reflecting dependency changes (should be separated from formatting changes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ed695e2 to
f92da7b
Compare
|
Hey, @ductrung-nguyen thanks for creating this PR. We will review it and get back to you as soon as possible |
|
thank you @patrykw-splunk. Hope that this PR and #1639 can be reviewed and merged soon to avoid further conflict. |
|
Hi @ductrung-nguyen, thank for this PR. One thing we need to make sure before merging is for you to sign CLA - can you fill out this form? |
|
Thanks @kubabuczak From developer console, I see that the response is "OK", but there are some errors on the UI: |
|
Not sure why the unit tests failed. There is no changes in the logic of the code. |
|
Regarding CLA sing up - I'm trying to contact people which may have more info about it - I'll get back to you as soon as I got something. Regarding tests - there is a problem with secrets and tokens - workflows for PRs from external forks don't have access to them, so many tests won't pass. It's surprisingly complex to set up correctly. |
|
@ductrung-nguyen - sorry for long time waiting for this CLA issue. Just want to say that we are still working on it, but I have a hard time to get to the right people :/ |
|
thank you very much. I completely understood the difficulties when setting the tests from external fork 😄 |
|
@ductrung-nguyen can you try again to sign CLA? Web team said that the issue is resolved |
|
it works. I can sign. Thank you very much. |


Description
Formatting the code properly
Key Changes
Testing and Verification
There is no change in the logic or in the tests
Related Issues
#1634
PR Checklist