Add a check if contributor has signed Splunk Contributor License Agreement #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 20303360958Details
💛 - Coveralls |
kasiakoziol
approved these changes
Dec 10, 2025
Collaborator
|
why MR to main directly? |
kubabuczak
reviewed
Dec 11, 2025
.github/workflows/cla-check.yml
Outdated
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # The below token should have repo scope and must be manually added by a maintainer in the GitHub Secrets | ||
| PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_ASSISTANT_PAT }} |
Collaborator
There was a problem hiding this comment.
Did you add this secret? I don't see it in our secrets in GitHub.
What is the TTL of this PAT? Should we track and manage expiration date?
kubabuczak
requested changes
Dec 11, 2025
Collaborator
kubabuczak
left a comment
kubabuczak
left a comment
There was a problem hiding this comment.
I would say that we should merge it to develop.
Do you have an example of execution of this workflow?
kubabuczak
reviewed
Dec 11, 2025
.github/workflows/cla-check.yml
Outdated
|
|
||
| # the following fields are optional | ||
| remote-organization-name: splunk | ||
| remote-repository-name: splunk-operator-cla-signatures |
Collaborator
There was a problem hiding this comment.
where is this repository?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kubabuczak
reviewed
Dec 16, 2025
.github/workflows/cla-check.yml
Outdated
| uses: cla-assistant/github-action@v2.1.3-beta | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PERSONAL_ACCESS_TOKEN: ${{ secrets.PAT_CLATOOL }} |
Collaborator
There was a problem hiding this comment.
Did you create this secret? I don't see it in our secrets.
added 2 commits
December 16, 2025 14:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist