-
Notifications
You must be signed in to change notification settings - Fork 127
CSPL-4372: Add approval gate workflow and integrate into existing Git… #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kubabuczak
wants to merge
16
commits into
develop
Choose a base branch
from
CSPL-4372-add-approval-gate-exec-in-target
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
65349ba
CSPL-4372: Add approval gate workflow and integrate into existing Git…
kubabuczak c9ac960
CSPL-4372: Update GitHub Actions to use checkout@v6 with merge commit…
kubabuczak e97904a
Potential fix for code scanning alert no. 183: Workflow does not cont…
kubabuczak 10ae2ca
Update GitHub Actions workflows to use actions/checkout@v4 for consis…
kubabuczak 60c7d46
Update GitHub Actions workflows to specify branches for pull_request_…
kubabuczak e8c5c12
Update distroless build-test-push workflow to include branch filters …
kubabuczak ea7ff8e
Refactor distroless build-test-push workflow to trigger on pull_reque…
kubabuczak 09fd53b
Integrate approval gate into distroless build-test-push workflow
kubabuczak 0e5846c
Add debug output for pull request details in approval gate workflow
kubabuczak be2ac54
Enhance approval gate workflow with detailed pull request JSON output
kubabuczak cba3ced
CSPL-4272 Update workflows to utilize commit SHA from approval gate a…
kubabuczak d1169a3
Potential fix for code scanning alert no. 222: Workflow does not cont…
kubabuczak 85f4c15
Add dependency on get-commit-info job in approval gate workflow
kubabuczak 3c29d08
Refactor build-test-push workflow by commenting out unit tests and re…
kubabuczak ae59ec1
Update distroless build-test-push workflow to trigger on specific bra…
kubabuczak 5be9f03
Enhance approval gate workflow with commit SHA and message retrieval
kubabuczak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| name: Approval Gate | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| environment-name: | ||
| description: 'Environment name for approval' | ||
| required: false | ||
| type: string | ||
| default: 'external-contributor-approval' | ||
| outputs: | ||
| commit-sha: | ||
| description: 'The commit SHA (PR head for PRs, pushed commit for push events)' | ||
| value: ${{ jobs.get-commit-info.outputs.commit-sha }} | ||
| commit-message: | ||
| description: 'The commit message' | ||
| value: ${{ jobs.get-commit-info.outputs.commit-message }} | ||
|
|
||
| jobs: | ||
| # Get commit info from the PR head (not the base branch). | ||
| # This is necessary because with 'pull_request_target', GITHUB_SHA and the default | ||
| # checkout point to the BASE branch, not the PR's code. We explicitly use | ||
| # 'github.event.pull_request.head.sha' to get the actual PR commit info. | ||
| # For 'push' events, we fall back to 'github.sha' (the pushed commit). | ||
| get-commit-info: | ||
| permissions: | ||
| contents: read | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| commit-sha: ${{ steps.get-sha.outputs.commit_sha }} | ||
| commit-message: ${{ steps.get-message.outputs.commit_message }} | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha || github.sha }} | ||
| - name: Get commit SHA | ||
| id: get-sha | ||
| run: | | ||
| COMMIT_SHA="${{ github.event.pull_request.head.sha || github.sha }}" | ||
| echo "commit_sha=${COMMIT_SHA}" >> $GITHUB_OUTPUT | ||
| echo "Commit SHA: ${COMMIT_SHA}" | ||
| - name: Get commit message | ||
| id: get-message | ||
| run: | | ||
| COMMIT_MSG=$(git log -1 --pretty=%B) | ||
| echo "commit_message<<EOF" >> $GITHUB_OUTPUT | ||
| echo "$COMMIT_MSG" >> $GITHUB_OUTPUT | ||
| echo "EOF" >> $GITHUB_OUTPUT | ||
| echo "Commit message:" | ||
| echo "$COMMIT_MSG" | ||
| approval-gate: | ||
|
||
| needs: get-commit-info | ||
| permissions: | ||
| contents: read | ||
| runs-on: ubuntu-latest | ||
| environment: ${{ | ||
| (github.event_name == 'pull_request_target' && | ||
| !contains(fromJSON('["MEMBER", "OWNER", "COLLABORATOR"]'), github.event.pull_request.author_association)) | ||
| && inputs.environment-name | ||
| || (github.event_name == 'pull_request' && inputs.environment-name) | ||
| || '' | ||
| }} | ||
| steps: | ||
| - name: Approval status | ||
| run: | | ||
| echo "Event: ${{ github.event_name }}" | ||
| echo "Author association: ${{ github.event.pull_request.author_association }}" | ||
| echo "Approval granted or not required" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.