Skip to content

Add Reader fuzz tests #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tigrannajaryan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Reader fuzz tests #300

tigrannajaryan wants to merge 1 commit into from

Conversation

@tigrannajaryan
Copy link
Collaborator

@tigrannajaryan tigrannajaryan commented Dec 18, 2025

  • Fuzz tests are generated for all readers.
  • Generated tests are executed with initial seeds as part of regular "make test" targets, but no fuzzing happens with regular runs.
  • Fuzzing can be done by executing "go test -fuzz ". After this PR is merged I will run fuzzing on my machine and will report/fix bugs found by fuzzer in separate PRs.

Contributes to #11

@tigrannajaryan
Add Reader fuzz tests
0c1e919 
- Fuzz tests are generated for all readers.
- Generated tests are executed with initial seeds as part of regular
  "make test" targets, but no fuzzing happens with regular runs.
- Fuzzing can be done by executing "go test -fuzz <testname>". After
  this PR is merged I will run fuzzing on my machine and will report/fix
  bugs found by fuzzer in separate PRs.

Contributes to #11
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Benchmark Result

Benchmark diff with base branch 
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │     sec/op     │    sec/op     vs base               │
SerializeNative/STEF/serialize-4                     11.77m ±  5%   12.34m ± 13%   +4.79% (p=0.004 n=6)
SerializeNative/STEFU/serialize-4                    35.32m ±  2%   35.28m ±  1%        ~ (p=0.589 n=6)
DeserializeNative/STEF/deser-4                       2.559m ±  1%   2.540m ±  1%        ~ (p=0.065 n=6)
DeserializeNative/STEFU/deser-4                      7.188m ±  0%   7.194m ±  0%        ~ (p=0.937 n=6)
SerializeFromPdata/STEF/serialize-4                  137.9m ±  5%   137.4m ±  8%        ~ (p=0.937 n=6)
SerializeFromPdata/STEFU/serialize-4                 35.36m ±  1%   35.46m ±  1%        ~ (p=0.180 n=6)
DeserializeToPdata/STEF/deserialize-4                45.72m ±  2%   46.11m ±  2%   +0.86% (p=0.041 n=6)
DeserializeToPdata/STEFU/deserialize-4               62.96m ±  1%   63.61m ±  2%        ~ (p=0.132 n=6)
STEFReaderRead-4                                     2.591m ±  1%   2.598m ±  2%        ~ (p=0.589 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4        3.345 ± 26%    3.310 ± 21%        ~ (p=0.818 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     73.23m ± 13%   82.64m ±  8%  +12.85% (p=0.041 n=6)
ReadSTEF-4                                           2.703m ±  3%   2.693m ±  3%        ~ (p=0.589 n=6)
ReadSTEFZ-4                                          3.715m ±  4%   3.631m ±  3%        ~ (p=0.240 n=6)
ReadSTEFZWriteSTEF-4                                 8.411m ±  2%   8.942m ±  3%   +6.31% (p=0.002 n=6)
geomean                                              21.88m         22.20m         +1.47%

                                                 │ bench-main.txt │            bench-new.txt             │
                                                 │   sec/point    │   sec/point    vs base               │
SerializeNative/STEF/serialize-4                     176.1n ±  5%    184.5n ± 13%   +4.77% (p=0.006 n=6)
SerializeNative/STEFU/serialize-4                    528.2n ±  2%    527.6n ±  1%        ~ (p=0.561 n=6)
DeserializeNative/STEF/deser-4                       38.27n ±  1%    37.99n ±  1%        ~ (p=0.065 n=6)
DeserializeNative/STEFU/deser-4                      107.5n ±  0%    107.6n ±  0%        ~ (p=0.827 n=6)
SerializeFromPdata/STEF/serialize-4                  2.063µ ±  5%    2.055µ ±  8%        ~ (p=0.909 n=6)
SerializeFromPdata/STEFU/serialize-4                 529.0n ±  1%    530.3n ±  1%        ~ (p=0.180 n=6)
DeserializeToPdata/STEF/deserialize-4                683.9n ±  2%    689.7n ±  2%   +0.86% (p=0.041 n=6)
DeserializeToPdata/STEFU/deserialize-4               941.9n ±  1%    951.6n ±  2%        ~ (p=0.132 n=6)
STEFReaderRead-4                                     38.74n ±  1%    38.85n ±  2%        ~ (p=0.589 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       4.251µ ± 26%    4.207µ ± 21%        ~ (p=0.818 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     93.08n ± 13%   105.00n ±  8%  +12.81% (p=0.041 n=6)
ReadSTEF-4                                           40.46n ±  3%    40.30n ±  3%        ~ (p=0.509 n=6)
ReadSTEFZ-4                                          55.59n ±  4%    54.35n ±  3%        ~ (p=0.240 n=6)
ReadSTEFZWriteSTEF-4                                 125.9n ±  2%    133.8n ±  3%   +6.27% (p=0.002 n=6)
geomean                                              230.1n          233.5n         +1.47%

                                                 │ bench-main.txt │            bench-new.txt             │
                                                 │      B/op      │     B/op      vs base                │
SerializeNative/STEF/serialize-4                     3.347Mi ± 0%   3.349Mi ± 0%       ~ (p=0.225 n=6)
SerializeNative/STEFU/serialize-4                    7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.680 n=6)
DeserializeNative/STEF/deser-4                       934.4Ki ± 0%   934.4Ki ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                      1.471Mi ± 0%   1.471Mi ± 0%       ~ (p=1.000 n=6) ¹
SerializeFromPdata/STEF/serialize-4                  74.82Mi ± 0%   74.82Mi ± 0%       ~ (p=0.619 n=6)
SerializeFromPdata/STEFU/serialize-4                 7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.400 n=6)
DeserializeToPdata/STEF/deserialize-4                31.97Mi ± 0%   31.97Mi ± 0%       ~ (p=0.690 n=6)
DeserializeToPdata/STEFU/deserialize-4               38.64Mi ± 0%   38.64Mi ± 0%       ~ (p=0.069 n=6)
STEFReaderRead-4                                     936.2Ki ± 0%   936.2Ki ± 0%       ~ (p=0.455 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       3.364Gi ± 0%   3.360Gi ± 0%       ~ (p=0.093 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     20.59Mi ± 0%   20.59Mi ± 0%       ~ (p=0.671 n=6)
ReadSTEF-4                                           936.2Ki ± 0%   936.2Ki ± 0%       ~ (p=0.266 n=6)
ReadSTEFZ-4                                          10.27Mi ± 0%   10.27Mi ± 0%       ~ (p=0.165 n=6)
ReadSTEFZWriteSTEF-4                                 13.43Mi ± 0%   13.43Mi ± 0%       ~ (p=0.329 n=6)
geomean                                              10.48Mi        10.48Mi       -0.00%
¹ all samples are equal

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   allocs/op    │  allocs/op   vs base                │
SerializeNative/STEF/serialize-4                      2.663k ± 0%   2.666k ± 0%       ~ (p=0.247 n=6)
SerializeNative/STEFU/serialize-4                      885.0 ± 0%    885.0 ± 0%       ~ (p=1.000 n=6)
DeserializeNative/STEF/deser-4                         465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                        469.0 ± 0%    469.0 ± 0%       ~ (p=1.000 n=6) ¹
SerializeFromPdata/STEF/serialize-4                   134.7k ± 0%   134.7k ± 0%       ~ (p=0.567 n=6)
SerializeFromPdata/STEFU/serialize-4                   886.0 ± 0%    886.0 ± 0%       ~ (p=1.000 n=6) ¹
DeserializeToPdata/STEF/deserialize-4                 756.2k ± 0%   756.2k ± 0%       ~ (p=1.000 n=6) ¹
DeserializeToPdata/STEFU/deserialize-4                944.9k ± 0%   944.9k ± 0%       ~ (p=1.000 n=6) ¹
STEFReaderRead-4                                       465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
STEFSerializeMultipart/astronomy-otelmetrics-4        13.15M ± 0%   13.15M ± 0%       ~ (p=0.937 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4      2.295k ± 0%   2.295k ± 0%       ~ (p=1.000 n=6)
ReadSTEF-4                                             466.0 ± 0%    466.0 ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZ-4                                            504.0 ± 0%    504.0 ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZWriteSTEF-4                                  1.234k ± 0%   1.234k ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               6.363k        6.363k       +0.01%
¹ all samples are equal
Benchmark result 
benchstat bench-new.txt
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-new.txt │
                                                 │    sec/op     │
SerializeNative/STEF/serialize-4                    12.34m ± 13%
SerializeNative/STEFU/serialize-4                   35.28m ±  1%
DeserializeNative/STEF/deser-4                      2.540m ±  1%
DeserializeNative/STEFU/deser-4                     7.194m ±  0%
SerializeFromPdata/STEF/serialize-4                 137.4m ±  8%
SerializeFromPdata/STEFU/serialize-4                35.46m ±  1%
DeserializeToPdata/STEF/deserialize-4               46.11m ±  2%
DeserializeToPdata/STEFU/deserialize-4              63.61m ±  2%
STEFReaderRead-4                                    2.598m ±  2%
STEFSerializeMultipart/astronomy-otelmetrics-4       3.310 ± 21%
STEFDeserializeMultipart/astronomy-otelmetrics-4    82.64m ±  8%
ReadSTEF-4                                          2.693m ±  3%
ReadSTEFZ-4                                         3.631m ±  3%
ReadSTEFZWriteSTEF-4                                8.942m ±  3%
geomean                                             22.20m

                                                 │ bench-new.txt │
                                                 │   sec/point   │
SerializeNative/STEF/serialize-4                    184.5n ± 13%
SerializeNative/STEFU/serialize-4                   527.6n ±  1%
DeserializeNative/STEF/deser-4                      37.99n ±  1%
DeserializeNative/STEFU/deser-4                     107.6n ±  0%
SerializeFromPdata/STEF/serialize-4                 2.055µ ±  8%
SerializeFromPdata/STEFU/serialize-4                530.3n ±  1%
DeserializeToPdata/STEF/deserialize-4               689.7n ±  2%
DeserializeToPdata/STEFU/deserialize-4              951.6n ±  2%
STEFReaderRead-4                                    38.85n ±  2%
STEFSerializeMultipart/astronomy-otelmetrics-4      4.207µ ± 21%
STEFDeserializeMultipart/astronomy-otelmetrics-4    105.0n ±  8%
ReadSTEF-4                                          40.30n ±  3%
ReadSTEFZ-4                                         54.35n ±  3%
ReadSTEFZWriteSTEF-4                                133.8n ±  3%
geomean                                             233.5n

                                                 │ bench-new.txt │
                                                 │     B/op      │
SerializeNative/STEF/serialize-4                    3.349Mi ± 0%
SerializeNative/STEFU/serialize-4                   7.530Mi ± 0%
DeserializeNative/STEF/deser-4                      934.4Ki ± 0%
DeserializeNative/STEFU/deser-4                     1.471Mi ± 0%
SerializeFromPdata/STEF/serialize-4                 74.82Mi ± 0%
SerializeFromPdata/STEFU/serialize-4                7.530Mi ± 0%
DeserializeToPdata/STEF/deserialize-4               31.97Mi ± 0%
DeserializeToPdata/STEFU/deserialize-4              38.64Mi ± 0%
STEFReaderRead-4                                    936.2Ki ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4      3.360Gi ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4    20.59Mi ± 0%
ReadSTEF-4                                          936.2Ki ± 0%
ReadSTEFZ-4                                         10.27Mi ± 0%
ReadSTEFZWriteSTEF-4                                13.43Mi ± 0%
geomean                                             10.48Mi

                                                 │ bench-new.txt │
                                                 │   allocs/op   │
SerializeNative/STEF/serialize-4                     2.666k ± 0%
SerializeNative/STEFU/serialize-4                     885.0 ± 0%
DeserializeNative/STEF/deser-4                        465.0 ± 0%
DeserializeNative/STEFU/deser-4                       469.0 ± 0%
SerializeFromPdata/STEF/serialize-4                  134.7k ± 0%
SerializeFromPdata/STEFU/serialize-4                  886.0 ± 0%
DeserializeToPdata/STEF/deserialize-4                756.2k ± 0%
DeserializeToPdata/STEFU/deserialize-4               944.9k ± 0%
STEFReaderRead-4                                      465.0 ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4       13.15M ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4     2.295k ± 0%
ReadSTEF-4                                            466.0 ± 0%
ReadSTEFZ-4                                           504.0 ± 0%
ReadSTEFZWriteSTEF-4                                 1.234k ± 0%
geomean                                              6.363k

@tigrannajaryan tigrannajaryan marked this pull request as ready for review December 18, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhisheksplunk abhisheksplunk Awaiting requested review from abhisheksplunk

@maheshkanote maheshkanote Awaiting requested review from maheshkanote

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tigrannajaryan